Loading adherence from server should not overwrite local changes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syoung-smallwisdom
approved these changes
Mar 11, 2024
Collaborator
syoung-smallwisdom
left a comment
syoung-smallwisdom
left a comment
There was a problem hiding this comment.
Looks good. One nit about using an object for clientData.
| assertNotNull(record) | ||
| assertEquals(instanceGuid, record.instanceGuid) | ||
|
|
||
| val updatedRecord = record.copy(clientData = JsonPrimitive("Test data")) |
Collaborator
There was a problem hiding this comment.
Can you change this to set the clientData as a JsonObject rather than a primitive? Since we need to be able to merge scheduling data that we set when updating the start times with app data that the app uses, this is always going to be an object. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.