[FIX] Fix missing X-TIMESTAMP-MAP header in WebVTT when no subtitles found #1772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that when running CCExtractor with the
--timestamp-mapflag on a video file that has no subtitles, the resulting WebVTT file was just empty with only "WEBVTT" at the top. TheX-TIMESTAMP-MAPheader was completely missing, which breaks HLS streaming compatibility.What I changed
write_webvtt_header()so it can write to a specific output fileX-TIMESTAMP-MAP=MPEGTS:0,LOCAL:00:00:00.000) when there's no timing info availablewrite_subtitle_file_footer()Fixes #1743
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Testing
Ran CCExtractor on a
.tsfile with no subtitles using the--timestamp-mapflag. Before this fix, the output was just "WEBVTT". Now it correctly outputs: