Skip to content

Fix scrollbars in settings and dashboard UI #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix scrollbars in settings and dashboard UI #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/screens/dashboard/dashboard.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ class SelectedFilesContainer extends StatelessWidget {
? Scrollbar(
child: ListView.builder(
shrinkWrap: true,
physics: ClampingScrollPhysics(),
physics: AlwaysScrollableScrollPhysics(),
itemCount:
settingsState.settingsModel.splitMode &&
state.files.length > 1
Expand Down Expand Up @@ -342,7 +342,7 @@ class LogsContainer extends StatelessWidget {
? Scrollbar(
controller: _scrollController,
child: ListView.builder(
shrinkWrap: true,
shrinkWrap: false,
controller: _scrollController,
itemBuilder: (context, index) {
return Padding(
Expand Down
6 changes: 4 additions & 2 deletions lib/screens/settings/basic_settings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,11 @@ class BasicSettingsScreen extends StatelessWidget {
),
body: Padding(
padding: const EdgeInsets.all(8.0),
child: ListView(
child: Scrollbar(
controller: controller,
children: [
child: ListView(
controller: controller,
children: [
CustomTextField(
title: 'Output file name (press enter to save)',
subtitle:
Expand Down
6 changes: 4 additions & 2 deletions lib/screens/settings/hardsubx_settings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,11 @@ class HardSubxSettingsScreen extends StatelessWidget {
),
body: Padding(
padding: const EdgeInsets.all(8.0),
child: ListView(
child: Scrollbar(
controller: controller,
children: [
child: ListView(
controller: controller,
children: [
CustomSwitchListTile(
title: 'HardSubx',
subtitle:
Expand Down
6 changes: 4 additions & 2 deletions lib/screens/settings/input_settings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ class InputSettingsScreen extends StatelessWidget {
),
body: Padding(
padding: const EdgeInsets.all(8.0),
child: ListView(
child: Scrollbar(
controller: controller,
children: [
child: ListView(
controller: controller,
children: [
CustomSwitchListTile(
title: 'Fix pts jumps',
subtitle:
Expand Down
6 changes: 4 additions & 2 deletions lib/screens/settings/obscure_settings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@ class ObscureSettingsScreen extends StatelessWidget {
),
body: Padding(
padding: const EdgeInsets.all(8.0),
child: ListView(
child: Scrollbar(
controller: controller,
children: [
child: ListView(
controller: controller,
children: [
CustomSwitchListTile(
title: 'Panasonic DMR-ES15',
subtitle:
Expand Down
6 changes: 4 additions & 2 deletions lib/screens/settings/output_settings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,11 @@ class OutputSettingsScreen extends StatelessWidget {
),
body: Padding(
padding: const EdgeInsets.all(8.0),
child: ListView(
child: Scrollbar(
controller: controller,
children: [
child: ListView(
controller: controller,
children: [
CustomSwitchListTile(
title: 'BOM',
subtitle:
Expand Down