Skip to content

feat: Improve tags add ux while adding task #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 19, 2024
Merged

feat: Improve tags add ux while adding task #399

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71fa85e
feat: add tag to tags array immediately after input whitespace
SGI-CAPP-AT2 Dec 15, 2024
cfc6c9a
feat: split tag input by whitespaces to avoid whitespaces in each tag
SGI-CAPP-AT2 Dec 15, 2024
9718a37
fix: remove tag if already exists in list and add again
SGI-CAPP-AT2 Dec 15, 2024
b2e8e0e
fix: removed `dart:ffi` added by recent commit
SGI-CAPP-AT2 Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions lib/app/modules/home/views/add_task_bottom_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,13 @@ class AddTaskBottomSheet extends StatelessWidget {
onFieldSubmitted: (tag) {
addTag(tag.trim());
},
onChanged: (value) {
String trimmedString = value.trim();
if (value.endsWith(" ") &&
trimmedString.split(' ').length == 1) {
addTag(trimmedString);
}
},
),
),
IconButton(
Expand Down Expand Up @@ -158,9 +165,9 @@ class AddTaskBottomSheet extends StatelessWidget {
),
validator: (name) => name != null && name.isEmpty
? SentenceManager(
currentLanguage: homeController.selectedLanguage.value)
.sentences
.addTaskFieldCannotBeEmpty
currentLanguage: homeController.selectedLanguage.value)
.sentences
.addTaskFieldCannotBeEmpty
: null,
);

Expand Down Expand Up @@ -400,9 +407,9 @@ class AddTaskBottomSheet extends StatelessWidget {
TextButton(
child: Text(
SentenceManager(
currentLanguage: homeController.selectedLanguage.value)
.sentences
.addTaskCancel,
currentLanguage: homeController.selectedLanguage.value)
.sentences
.addTaskCancel,
style: TextStyle(
color: AppSettings.isDarkMode
? TaskWarriorColors.white
Expand All @@ -425,8 +432,8 @@ class AddTaskBottomSheet extends StatelessWidget {
child: Text(
SentenceManager(
currentLanguage: homeController.selectedLanguage.value)
.sentences
.addTaskAdd,
.sentences
.addTaskAdd,
style: TextStyle(
color: AppSettings.isDarkMode
? TaskWarriorColors.white
Expand Down Expand Up @@ -472,8 +479,8 @@ class AddTaskBottomSheet extends StatelessWidget {
content: Text(
SentenceManager(
currentLanguage: homeController.selectedLanguage.value)
.sentences
.addTaskTaskAddedSuccessfully,
.sentences
.addTaskTaskAddedSuccessfully,
style: TextStyle(
color: AppSettings.isDarkMode
? TaskWarriorColors.kprimaryTextColor
Expand Down Expand Up @@ -519,11 +526,19 @@ class AddTaskBottomSheet extends StatelessWidget {
void addTag(String tag) {
if (tag.isNotEmpty) {
String trimmedString = tag.trim();
homeController.tags.add(trimmedString);
List<String> tags = trimmedString.split(" ");
for(tag in tags){
if(checkTagIfExists(tag)) {
removeTag(tag);
}
homeController.tags.add(tag);
}
homeController.tagcontroller.text = '';
}
}

bool checkTagIfExists(String tag){
return homeController.tags.contains(tag);
}
void removeTag(String tag) {
homeController.tags.remove(tag);
}
Expand Down
Loading