Skip to content

Conversation

@D-extremity
Copy link

@D-extremity D-extremity commented Dec 16, 2024

closes #400

  1. Refactor: Centralize theme logic using ThemeData to remove redundant checks
  2. Fix: Replace multiple theme checks with global ThemeData implementation
  3. Updated notification dependency to the newest which is possible without changing any implementation

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@D-extremity D-extremity changed the title Updated dependencies Updated dependencies and reduced repeated code Dec 16, 2024
@BrawlerXull
Copy link
Contributor

Please refactor the whole codebase where ever the old logic is used.
Also avoid pushing files like macos/Flutter/GeneratedPluginRegistrant.swift or updating dependancies in the same pr

@D-extremity
Copy link
Author

Please refactor the whole codebase where ever the old logic is used. Also avoid pushing files like macos/Flutter/GeneratedPluginRegistrant.swift or updating dependancies in the same pr

okay i will make a separate PR, change in macos/Flutter/GeneratedPluginRegistrant.swift was of dependency that's why its changed and it came in PR.
Thanks for reviewing, i will PR soon

@D-extremity D-extremity mentioned this pull request Dec 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

fix: Avoid multiple theme checks

2 participants