fix unit test #669
Merged
fix unit test #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sei-vsarvepalli
approved these changes
Jan 22, 2025
also use with... syntax to reduce filehandler boilerplate
Contributor
Author
|
Because our schemas are nested (they have internal pointers to other schemas we also run out of this repo), we can't just say "load the schema from a local file path" and be done with it. We appear to need the retrieval intercept that rewrites our URIs to file paths and loads from there. There might be something more we could do with the schema validator object, but that's going deeper into the validator API than I think we need to at this point. I'm going to merge this since the tests work as-is. If we need to improve the tests, let's do a separate issue for that. |
ahouseholder
added a commit
that referenced
this pull request
Jan 24, 2025
* fix unit test * add some comments explaining why we're doing it this way also use with... syntax to reduce filehandler boilerplate
ahouseholder
added a commit
that referenced
this pull request
Jan 27, 2025
* fix unit test (#669) * fix unit test * add some comments explaining why we're doing it this way also use with... syntax to reduce filehandler boilerplate * use pydantic dataclasses makes json roundtrip easier also prepares for FastAPI adoption # Conflicts: # src/ssvc/_mixins.py # src/ssvc/decision_points/cvss/base.py # src/ssvc_v2.py * black reformat * fix unit tests * black reformat * use native python types * update dependencies * wrap scripts in main() func * regenerate with indented json * black reformat * add placeholder test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON schema unit tests were failing because the local path substitution wasn't working consistently across different environments. This PR fixes that by computing a relative path from the test file in which it is called.