Skip to content

Replace python dataclasses with pydantic dataclasses #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahouseholder merged 12 commits into from
Jan 27, 2025
Merged

Replace python dataclasses with pydantic dataclasses #674

ahouseholder merged 12 commits into from
Jan 27, 2025

Conversation

@ahouseholder
Copy link
Contributor

@ahouseholder ahouseholder commented Jan 24, 2025

Rationale:

  • sets us up for future FastAPI microservice development
  • removes dependency on dataclasses-json
  • improves our ability to use validators on object creation

ahouseholder and others added 6 commits January 24, 2025 10:58
@ahouseholder
fix unit test (#669)
4254876 
* fix unit test

* add some comments explaining why we're doing it this way

also use with... syntax to reduce filehandler boilerplate
@ahouseholder
use pydantic dataclasses
b938c1a 
makes json roundtrip easier
also prepares for FastAPI adoption

# Conflicts:
#	src/ssvc/_mixins.py
#	src/ssvc/decision_points/cvss/base.py
#	src/ssvc_v2.py
@ahouseholder
black reformat
11c7c2b
@ahouseholder
fix unit tests
eab9ecb
@ahouseholder
black reformat
d00f302
@ahouseholder
use native python types
caac659
@ahouseholder ahouseholder self-assigned this Jan 24, 2025
@ahouseholder ahouseholder added enhancement New feature or request tools Software Tools labels Jan 24, 2025
@ahouseholder ahouseholder added this to the 1Q25 milestone Jan 24, 2025
@ahouseholder ahouseholder mentioned this pull request Jan 24, 2025
Merged
ahouseholder
ahouseholder commented Jan 24, 2025
View reviewed changes
ahouseholder
ahouseholder commented Jan 24, 2025
View reviewed changes
ahouseholder
ahouseholder commented Jan 24, 2025
View reviewed changes
Copy link
Contributor Author

@ahouseholder ahouseholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole commit was just me regenerating the json files with the fixed scripts

sei-vsarvepalli
sei-vsarvepalli approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pydantic it is now.

@ahouseholder ahouseholder merged commit 2dd69f0 into main Jan 27, 2025
4 checks passed
@ahouseholder ahouseholder deleted the feature/use_pydantic branch January 27, 2025 15:12
This was referenced Feb 19, 2025
Closed
Merged
This was referenced Feb 20, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sei-vsarvepalli sei-vsarvepalli sei-vsarvepalli approved these changes

@cgyarbrough cgyarbrough Awaiting requested review from cgyarbrough cgyarbrough is a code owner

Assignees

@ahouseholder ahouseholder

Labels

enhancement New feature or request tools Software Tools

Projects

None yet

Milestone

2025-03

Development

Successfully merging this pull request may close these issues.

Switch from python dataclasses to pydantic BaseModel dataclasses

3 participants

@ahouseholder @sei-vsarvepalli