Split CVSS equivalence sets #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sei-vsarvepalli
approved these changes
Feb 18, 2025
Contributor
sei-vsarvepalli
left a comment
sei-vsarvepalli
left a comment
There was a problem hiding this comment.
See comments on the PR #683 on the test cases Python file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor to #329. It does not resolve it though.
When we originally added objects for the CVSS v4 equivalence sets, we put them all into one module. However, since we expect them to basically be treated as decision points, we want them to be in separate files going forward to retain consistency in how we map decision points to python files.
The main changes involve the removal of the old equivalence sets and the creation of new, separate modules for each equivalence set. Additionally, there are some updates to the module documentation to improve clarity.
Documentation Updates:
src/ssvc/_mixins.py: Updated the module docstring to provide a clearer description of the module's purpose.Removal of Old Equivalence Sets:
src/ssvc/decision_points/cvss/eq_sets.py: Removed the old equivalence sets and their associated decision points and values.Creation of New Equivalence Set Modules:
src/ssvc/decision_points/cvss/equivalence_set_1.py: Added a new module for Equivalence Set 1, including its decision points and values.src/ssvc/decision_points/cvss/equivalence_set_2.py: Added a new module for Equivalence Set 2, including its decision points and values.src/ssvc/decision_points/cvss/equivalence_set_3.py: Added a new module for Equivalence Set 3, including its decision points and values.src/ssvc/decision_points/cvss/equivalence_set_4.py: Added a new module for Equivalence Set 4, including its decision points and values.src/ssvc/decision_points/cvss/equivalence_set_5.py: Added a new module for Equivalence Set 5, including its decision points and values.src/ssvc/decision_points/cvss/equivalence_set_6.py: Added a new module for Equivalence Set 6, including its decision points and values.Import and Group Updates:
src/ssvc/dp_groups/cvss/collections.py: Updated imports to reference the new equivalence set modules and adjusted the decision points group accordingly. [1] [2]