Add class RecHitCommonMode

[mengleisun]

Add a class "RecHitCommonMode" to estimate the common mode noise.
A new plugin "RecHitPlotter_HighGain_CM_Correction.cc" was created to illustrate the use of the RecHitCommonMode class.
test_cfg_2.py was modified based on the test_cfg.py to test the new plugin.

[shervin86]

The CellType should already be defined in some header file.

[shervin86]

Dear Menglei, thanks for the module. Can we discuss and fix the small issues I pointed out?

[mengleisun]

@shervin86
Hi Shervin,
Thank you for pointing out the issues in the code. I will fix them and push the changes later today.
I was wondering if you know in which file the cellType is defined? I checked the DataFormat and Geometry directory, however, it seems that the "cellType()" function will only return an integer number indicating the cell type. I think a mapping between int numbers and string type names will be more straightforward.
For the getCommonModeNoise() function, I will change the input variables to detId.

Let me know if anything else need to be modified/added.

cheers,
Menglei

[rchatter]

Hi Menglei,

The cellType is one of the parameters that define a Det Id. So for a unique
Det Id we need to provide this parameter.
I have followed the following convention for the cells:
0: Full Hex
1: Calib Pad
2: Half Hex
3: Mouse bite/ Merged cell
4: Outer calib pad
The information of electronics channel to Det Id is contained in the
electronics map. So if you have a look at the Electronics Map in
CondObjects/data you will see in the mapping file there is a column for
cell type for the channel mapped to det id in each row.

Thus post unpacking the digis and the rechits for that matter have the
adc/ped subtracted information for each cell hence detid. From the detid of
the rechit you may use the cellType() function to detemine what type of
cell it is based on the above.

If we agree that having a int -> char[]/string map is more convenient
Shervin or I or you could put this in.

thanks,
Rajdeep

On Mon, Aug 29, 2016 at 8:44 AM, mengleisun notifications@github.com
wrote:

@shervin86 https://github.com/shervin86
Hi Shervin,
Thank you for pointing out the issues in the code. I will fix them and
push the changes later today.
I was wondering if you know in which file the cellType is defined? I
checked the DataFormat and Geometry directory, however, it seems that the
"cellType()" function will only return an integer number indicating the
cell type. I think a mapping between int numbers and string type names will
be more straightforward.
For the getCommonModeNoise() function, I will change the input variables
to detId.

Let me know if anything else need to be modified/added.

cheers,
Menglei

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFxLxGkPY-rEscodVoDbfQlvL0Jw25qpks5qkuImgaJpZM4JuaCH
.

Rajdeep.Mohan.Chatterjee
Post Doctoral Fellow
School of Physics and Astronomy
University of Minnesota
115 Union Street Street SE
Minneapolis MN 55455
USA

[mengleisun]

Hi all,

I have change the input argument of the getCommonModeNoise() function to DetId.

@shervin86, would you like me to remove the enum type of cellType, or keep it / move it to somewhere else?

thanks,
Menglei

[shervin86]

new branch with partial modifications: mergingPR7