Fix assertion extraction in CryptoAnalysis tests #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissiety
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting the assertions from the test methods, CryptoAnalysis considers only the orgininal test method and no other methods. This is because it tries to traverse the call graph in opposite direction, i.e. it tries to find other methods by looking on edges that lead into the test method. However, since the test method is the entry point, there are no other methods. Instead, it has to check the methods that are exiting the test method, i.e. the methods out of the initial test method. Recursively, CryptoAnalysis then checks all reachable methods in the call graph.
Thanks to @Hazem-Gamall for spotting this mistake