Skip to content

Conversation

dalpasso
Copy link
Collaborator

@dalpasso dalpasso commented Oct 1, 2025

Adopt EODAG's request validation. The validation is enabled via configuration (enabled by default).

Endpoint where validation is enabled:

  • /search
  • /collections/{collection_id}/order

@dalpasso dalpasso self-assigned this Oct 1, 2025
Copy link

github-actions bot commented Oct 1, 2025

Test Results

  2 files  ± 0    2 suites  ±0   19s ⏱️ -1s
 93 tests + 6   92 ✅ + 6  0 💤 ±0  1 ❌ ±0 
186 runs  +12  184 ✅ +12  0 💤 ±0  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit dc9e985. ± Comparison against base commit 8389893.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 1, 2025

badge

Code Coverage

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------
eodag/__init__.py                            0       0  100.00%
eodag/api.py                                 8       8  0.00%    20-37
eodag/app.py                                75      15  80.00%   149, 163-170, 181-183, 232-244, 248
eodag/client.py                             25       0  100.00%
eodag/config.py                             19       0  100.00%
eodag/constants.py                           6       0  100.00%
eodag/core.py                              278      53  80.94%   131-132, 142, 276-277, 357, 477-482, 492-493, 514, 529-547, 610-611, 635, 651-655, 669-673, 675-679, 684, 696-728
eodag/cql_evaluate.py                       48      27  43.75%   43, 48, 53, 58, 74-99, 104-106, 111
eodag/dag.py                                53       0  100.00%
eodag/errors.py                             94      12  87.23%   143, 160-163, 179, 202-212
eodag/logs.py                               62       9  85.48%   40-49, 105
eodag/middlewares.py                        32       2  93.75%   20, 24
eodag/telemetry.py                          44       0  100.00%
eodag/utils.py                              41      13  68.29%   44, 68-73, 86, 90-98, 134
eodag/eodag_types/__init__.py                0       0  100.00%
eodag/eodag_types/queryables.py             42      12  71.43%   45-51, 61, 77-81
eodag/eodag_types/search.py                 25      25  0.00%    20-69
eodag/extensions/collection_order.py        71       1  98.59%   106
eodag/extensions/data_download.py          111      38  65.77%   60-72, 93, 111-112, 119, 134-141, 146-147, 154-182
eodag/extensions/ecmwf.py                   69       0  100.00%
eodag/extensions/filter.py                  55       2  96.36%   196-197
eodag/extensions/offset_pagination.py       12       0  100.00%
eodag/extensions/pagination.py              15       0  100.00%
eodag/extensions/stac.py                   132       0  100.00%
eodag/models/__init__.py                     0       0  100.00%
eodag/models/links.py                      133      13  90.23%   36, 90-92, 185, 203, 235, 282, 331-342
eodag/models/stac_metadata.py              186       8  95.70%   98, 181, 183, 196-203, 261
TOTAL                                     1636     238  85.45%

Diff against main

Filename                                Stmts    Miss  Cover
------------------------------------  -------  ------  --------
eodag/config.py                            +1       0  +100.00%
eodag/core.py                              +2       0  +0.14%
eodag/extensions/collection_order.py       +6      -2  +3.21%
TOTAL                                      +9      -2  +0.20%

Results for commit: dc9e985

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

@dalpasso dalpasso force-pushed the validate-search-and-order-requests branch from 06e288b to 779176e Compare October 1, 2025 10:48
@dalpasso dalpasso marked this pull request as ready for review October 2, 2025 14:04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failure is not caused by this PR cause tests/test_download.py::test_download_item_from_collection_stream fails on the branch main. See for example this run. An issue has already been opened: #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants