Documentation and legibility fixes; less is more #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
junousi
commented
May 4, 2022
junousi
commented
- Since account/meta/regr/privkey variables don't seem to be in use, remove them.
- Add variable example defaults for relevant variables
- Add example of using a proxy in cronjob
- Expand the block condition for registration + cert retrieval into a list. This block should probably be carved into separate assertions, but leaving that for another PR.
junousi
commented
May 5, 2022
| #sectigo_emailAddress: contact@org | ||
|
|
||
| sectigo_domains: "{{ ansible_fqdn }}" | ||
| #sectigo_eab_kid: received_from_provider |
There was a problem hiding this comment.
Not all people use vault. But if considered beneficial or if desireable to use the existing pattern, I can still change this to e.g.
#sectigo_eab_kid: vault_sectigo_eab_kid
#sectigo_eab_hmac_key: vault_sectigo_eab_hmac_key
junousi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.