Skip to content

Dynamic classes are not overqualified #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dynamic classes are not overqualified #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rules/overqualified-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ CSSLint.addRule({
modifier = part.modifiers[k];
if (part.elementName && modifier.type === "id"){
reporter.report("Element (" + part + ") is overqualified, just use " + modifier + " without element name.", part.line, part.col, rule);
} else if (modifier.type === "class"){
} else if (modifier.type === "class" && modifier.text.indexOf(".ng-") === -1) {

if (!classes[modifier]){
classes[modifier] = [];
Expand Down
5 changes: 5 additions & 0 deletions tests/rules/overqualified-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
Assert.areEqual(0, result.messages.length);
},

"Using a dynamic class with an element should not result in a warning": function(){
var result = CSSLint.verify("a.ng-hide { float: left;}", { "overqualified-elements": 1 });
Assert.areEqual(0, result.messages.length);
},

"Using a class with an element should result in one warning": function(){
var result = CSSLint.verify("li.foo { float: left;}", { "overqualified-elements": 1 });
Assert.areEqual(1, result.messages.length);
Expand Down