Skip to content

fix: Function to handle BigInt value in JSON.stringify #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Function to handle BigInt value in JSON.stringify #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/condition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict'

import debug from './debug'
import { jsonStringifyWithBigInt } from './utils'

export default class Condition {
constructor (properties) {
Expand Down Expand Up @@ -101,9 +102,9 @@ export default class Condition {
]).then(([rightHandSideValue, leftHandSideValue]) => {
const result = op.evaluate(leftHandSideValue, rightHandSideValue)
debug(
`condition::evaluate <${JSON.stringify(leftHandSideValue)} ${
`condition::evaluate <${jsonStringifyWithBigInt(leftHandSideValue)} ${
this.operator
} ${JSON.stringify(rightHandSideValue)}?> (${result})`
} ${jsonStringifyWithBigInt(rightHandSideValue)}?> (${result})`
Copy link
Collaborator

@chris-pardy chris-pardy Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid a custom stringifier here when we can instead rely on the console.log built-in formatter if we change the signature of debug

)
return {
result,
Expand Down
7 changes: 7 additions & 0 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export function jsonStringifyWithBigInt (data) {
return JSON.stringify(data,
(key, value) => {
return typeof value === "bigint" ? value.toString() : value;
}
)
}