-
Notifications
You must be signed in to change notification settings - Fork 44
feat(rs): python udf deprecation scaffolding #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(rs): python udf deprecation scaffolding #563
Conversation
|
Dedicated environment removed |
|
Dedicated dedicated_563_carto environment deployed in Redshift host redshift-serverless-shared.515242991920.us-east-1.redshift-serverless.amazonaws.com and carto_dev_data database
|
|
Dedicated environment removed |
|
Dedicated dedicated_563_carto environment deployed in Redshift host redshift-serverless-shared.515242991920.us-east-1.redshift-serverless.amazonaws.com and carto_dev_data database
|
Jesus89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I have one question. Are the placekey, quadbin, quadkey, random and s2 public functions explicitly removed?
Regarding this point. I've not really removed these modules, but moved most of the implementations to the gateway folder. I've done it that in functions that doesn't have multiple of complex wrappers on top. An example, In other words the gateway folder structure should be able to take care of everything: deploying lambdas, external functions SQL (or full function sql implementations), unit tests and integrations tests. I've just migrated the minimum necessary (internal functions and functions with no or small wrappers) but the whole redshift (or others clouds) could be migrated. |
|
OK, I see. Thanks for confirming. |
Description
Shortcut
Also including:
Some changes to take into account:
cloud=redshift.RS_LAMBDA_PREFIX(10 characters or less) are expected. Also each lambda gets a simplified name.gateway/functions/_sharedwith shared code in order to avoid duplication. It's relevant specially in tilers, data... Please notice that due to it and including handlers some old code has been reorganised. I've tried to avoid as many changes as possible comparing with the original.Type of change
Acceptance
Tests done:
Repository rules
make lint,make lint-fixmake test,make test-unit,make test-integrationmake deploy cloud=redshift(from the root of the repo and gateway). Also with filters.make create-package cloud=redshift. Also with filters. Depending of it including lds, import, etc. it will slightly change the readme generated and add steps to SETUP the cloud native gateway connection.Created package installation
Others