Skip to content

Fix TransactionBuilder failing to debug P2PKH-only transactions #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025

Conversation

mainnet-pat
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cashscript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 9:48am

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (248870b) to head (621f6df).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   97.36%   97.40%   +0.03%     
==========================================
  Files          78       78              
  Lines       17920    17926       +6     
  Branches     1144     1336     +192     
==========================================
+ Hits        17448    17461      +13     
+ Misses        470      456      -14     
- Partials        2        9       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rkalis
Copy link
Member

rkalis commented Aug 5, 2025

Thanks pat for this PR!

We rebased and added some extra (skipped) tests.

We realised that it would be nice to have proper evaluation also for P2PKH inputs, but that is currently not how the debugging tools work, so just skipping the debugging if it's only P2PKH (like you did here) makes a lot of sense.

We did add some skipped tests and we have an issue (#323) that discusses improving the handling of P2PKH inputs in the future.

@rkalis rkalis merged commit 280c566 into CashScript:master Aug 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No placeholder scenario ID or script ID found
2 participants