[ENG-8475] | fix unable to render spreadsheet files (.xls and .xlsx) #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
approved these changes
Jul 29, 2025
Comment on lines
+16
to
+21
| • .xls → xlrd | ||
| • .xlsx → openpyxl (xlrd ≥2.0 dropped xlsx support) | ||
| `fp` is the stream returned by WaterButler/MFR. It may already have been | ||
| read, so we always rewind and copy to an in‑memory buffer that openpyxl (and | ||
| ZipFile) can seek inside safely. |
| wb = xlrd.open_workbook(file_contents=to_bytes(fp)) | ||
| return parse_xls(wb, sheets) | ||
| except xlrd.biffh.XLRDError: | ||
| pass |
There was a problem hiding this comment.
I see. We give it a try with xlrd. If failed, we try with openpyxl. I think reasons other than xlsx can cause xlrd.biffh.XLRDError but I think it's fine.
Comment on lines
+34
to
+36
| raise xlrd.biffh.XLRDError( | ||
| "Invalid xlsx file or corrupted ZIP structure" | ||
| ) from exc |
There was a problem hiding this comment.
Yep, this answered my previous questions.
cslzchen
merged commit d4da5a8
into
CenterForOpenScience:feature/buff-worms
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Changes
Side effects
QA Notes
Deployment Notes