Skip to content

[ENG-9901] [gizmo-mfr] Small xlsx file fails to preview/render #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antkryt wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ENG-9901] [gizmo-mfr] Small xlsx file fails to preview/render #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mfr/extensions/tabular/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import re
import xlrd
from datetime import datetime

from http import HTTPStatus
from subprocess import (check_call,
Expand Down Expand Up @@ -114,12 +115,18 @@ def to_bytes(fp):
raise TypeError("Expected binary file-like object; got text/str")


def _convert_value(value):
if isinstance(value, datetime):
return value.isoformat()
return value


def _extract_rows(fields, raw_rows):
rows = []
for row in raw_rows:
if len(rows) >= MAX_SIZE:
break
rows.append(dict(zip(fields, row)))
rows.append(dict(zip(fields, map(_convert_value, row))))
return rows


Expand Down