Basic support for glTF LINES primitive mode #1704
Conversation
ie list of segments: wouldn't be hard to support line loops and strips I guess, but I'd need a dataset to test that. No support for rendering with "attenuation" like point clouds: haven't looked at the custom vertex factory and shader yet to see how hard it would be to support lines. Probably need to change the name of CesiumGltfPointsComponent and proxy, unless it makes more sense to duplicate them.
GhisBntly
force-pushed
the
basic-lines-support
branch
from
b38fb4c to
6443579
Compare
There was a problem hiding this comment.
Thanks @GhisBntly for the PR! I don't think it would be much of a lift to add support for LINES, so feel free to keep working on this!
I would first suggest creating a separate CesiumGltfLinesComponent to detangle this implementation from the point one. You might find this #1037 a useful reference; it was the first PR where we added point support without worrying about attenuation.
Some of the SceneProxy / VertexFactory stuff is to support point attenuation. Basically we turn the points into billboarded quads to render them at a larger size, giving the point cloud a more opaque appearance. I'm not sure what line attenuation would look like, but it might help if you have any examples ^^
|
Thanks for the prompt feedback, @j9liu. |
This is the result of hacking quick support for these lines in order to test a model I really wanted to see but that only had lines in it... ,^^
But I'm opening a draft PR in order to get feedback already, because I found it almost suspicious that lines weren't supported if it were that easy! Anything I'm missing?
I find this feature useful even without attenuation support, what do you think? I won't have much more time to work on this as it was never really part of my assignments...
TODO:
CHANGES.mdSample result: no screen capture because this is user data, sorry! Will try to find lines in one of our own models.