-
Notifications
You must be signed in to change notification settings - Fork 3.7k
3d tiles terrain #12963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jjhembd
wants to merge
55
commits into
main
Choose a base branch
from
3d-tiles-terrain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
3d tiles terrain #12963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ior that resolves values immediately
3D Tiles terrain water mask
|
Thank you for the pull request, @jjhembd! ✅ We can confirm we have a CLA on file for you. |
jjhembd
commented
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds experimental support for loading 3D Tiles as terrain, via
Cesium3DTilesTerrainProvider.What 3D Tiles data can be used?
3D Tiles loaded with Cesium3DTilesTerrainProvider must follow this structure (thanks @lilleyse for the list):
TILE_MINIMUM_HEIGHT,TILE_MAXIMUM_HEIGHT,TILE_BOUNDING_SPHERE,TILE_HORIZON_OCCLUSION_POINTsemanticsPOSITIONattributeNORMALattribute ifrequestVertexNormalsis trueUNSIGNED_SHORTorUNSIGNED_INTcomponent typerequestWaterMaskis true, primitive must reference anEXT_structural_metadataproperty texture withWATERMASKsemantic.CESIUM_tile_edgesextensionEXT_meshopt_compression/KHR_mesh_quantizationIssue number and link
Resolves #12296
Testing plan
Cesium3DTilesTerrainProviderSpecandCesium3DTilesTerrainDataSpecTODO before moving this out of "Draft":
Checkcalls:EllipsoidalOccluder,GoogleEarthEnterpriseTerrainData,TerrainEncoding(separate from other changes in file),binarySearch,mergeSort,QuantizedMeshTerrainDataSpec. Beware incorrect capitalizations like{Object},{Number[]}! See Clean up docs and type checks for terrain providers #12969ResourceCache, avoid additional URI parsing.Consider dropping the duplicateThe two versions ofImplicitSubtreeCacheinCesium3DTilesTerrainProvider.js(replace withImplicitSubtreeCache.js)ImplicitSubtreeCachehave some key differences, so I think a refactor is out of scope for this PR.TerrainEncodingAuthor checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change