Skip to content

Conversation

@jjspace
Copy link
Contributor

@jjspace jjspace commented Oct 23, 2025

Description

Follow up to #12990 to fix a eslint warning in our React hooks for Sandcastle.

This change shouldn't affect functionality at all. if anything it may have a very minor improvement for performance during re-renders.

We may want to turn off --quiet mode on eslint since we don't actually have any warnings but that's a separate discussion.

Issue number and link

no issue

Testing plan

  • Run npx eslint "./**/*.js" "./**/*.cjs" "./**/*.html" to make sure no errors or warnings show up
  • Sandcastle should operate exactly as it does now. maybe slightly better performance
  • Check that loading sandcastles, running them and re-running them all work as expected

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@github-actions
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@mzschwartz5 mzschwartz5 added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 5ac1b07 Oct 24, 2025
10 checks passed
@mzschwartz5 mzschwartz5 deleted the react-eslint-warning branch October 24, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants