Update CAIP-285: Allow partial revokes via wallet_revokeSession
#379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
approved these changes
Sep 25, 2025
Collaborator
|
@pedrouid is there someone at reown to tag about this, specifically the people who worked out the solana wallet adapter stuff maybe? |
Member
|
IMHO this defies a bit the purpose of "wallet_revokeSession" which was analogous to disconnect or delete This seems better as a new RPC method that handles the partial part |
bumblefudge
reviewed
Oct 8, 2025
| { | ||
| "id": 1, | ||
| "jsonrpc": "2.0", | ||
| "method": "wallet_revokeSession", |
Collaborator
There was a problem hiding this comment.
@pedrouid made a good point that this doesn't map well to CRUD -- reduceSession, maybe? separate CAIP so as not to add a MUST? non blocking, just ideas to discuss at next call without a full agenda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests an update to the CAIP-285 specification, to introduce the new parameter to the
wallet_revokeSessionfunction, allowing for partial session revokes.