This repository was archived by the owner on May 9, 2024. It is now read-only.
Scoping #490
Open
Scoping #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: .gitignore README.md contracts/Bridge.sol package-lock.json package.json
|
|
mrwillis
commented
Feb 28, 2022
| } | ||
|
|
||
| // if we are dealing with Polygon ERC20 SX bridged over, call SXVault contract to send native SX | ||
| if (resourceID == sxResourceID) { |
There was a problem hiding this comment.
Change here to support sending native SX from a vault contract
mrwillis
commented
Feb 28, 2022
|
|
||
| address public _owner; | ||
| address public _sxVaultContract; | ||
| bytes32 sxResourceID = 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF; |
|
|
mrwillis
commented
Mar 3, 2022
| if (_burnList[tokenAddress]) { | ||
| burnERC20(tokenAddress, depositer, amount); | ||
| // 'burn' ERC20 that does not implement ERC20Burnable 'burnFrom()' | ||
| manualBurnERC20(tokenAddress, depositer, amount); |
There was a problem hiding this comment.
Burn tokens manually instead of using burnFrom
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've made two changes to the handlers to support a 1 way bridge from source chain to destination chain. The first change is changing the way tokens are burnt on the source side. We create a new method
manualBurnERC20which will send tokens to the0x000000000000000000000000dEAdaddress to support burning of tokens that don't haveburnFrom.Second change is supporting native asset redemptions on the dest side. We have a custom vault contract that
ERC20SxHandleruses to pull assets from. We use a custom resourceId0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFto denote that we want different logic on the dest side instead of the standardERC20Handlermint logic.Final change unrelated to above is adding a few more events to aid in integration with front-ends.