Skip to content

Make HttpClient public #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2024
Merged

Make HttpClient public #97

merged 1 commit into from
Sep 5, 2024

Conversation

chrisbanes
Copy link
Contributor

@chrisbanes chrisbanes commented Sep 1, 2024 •
edited
Loading

There's no real reason to hide it, as it stops calling being able to customize or tweak the client later.

Also made it lazily instantiated.

@chrisbanes
Make HttpClient public
719ea2f 
There's no real reason to hide it, and it stops calling being able to
customize or tweak the client later.

Also made it lazily instantiated.
@ChrisKruegerDev ChrisKruegerDev merged commit bcefd40 into ChrisKruegerDev:main Sep 5, 2024
2 checks passed
@ChrisKruegerDev
Copy link
Owner

Thank you!
@chrisbanes Do you need a new product version or does the snapshot version fit for you? I had my focus on another project in the last week.

@chrisbanes
Copy link
Contributor Author

snapshot works!

@chrisbanes chrisbanes deleted the patch-1 branch September 5, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbanes @ChrisKruegerDev