Fixing typos and removing abbreviations #291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the routing parameter
I am unsure if "node" shouldn't be something like "node_index" as I have not looked at where and how this is called. No type hints available yet. Will fix in the future if there is a mismatch in expectations.X
I am unsure if this is really the node, or an index for a node. But it should be fine as a local variable.
Contributor
Author
|
I recorded some videos while making these changes. They just show me making most of the changes. This gives some evidence that the changes are not AI slop and showcases the tool I used to make the changes. The typos-cli does provide a "write changes" option, but I wanted to manually inspect each part of the code myself and make the commits small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abbreviations
Google style suggests that we avoid abbreviations when naming variables. I didn't go after every abbreviation in the code base, but where typos was identifying typos-cli that were actually just abbreviations I updated them.
Typos
I tried to fix all typos detected by typos-cli, which were primarily spelling mistakes.