Skip to content

Conversation

@pjhampton
Copy link
Member

@pjhampton pjhampton commented Sep 26, 2025

Improved progress bar positioning to appear directly under file name text for both FileUpload and FileMultiUpload components. Aligns with changes @crisalbu gave me. It is backward compatible so no concerns for control plane usages.

  • Enhanced state management to prevent conflicting UI states (success overrides progress)
  • Standardised typography and layout consistency across upload components
  • Replaced inline styles with maintainable styled components

@pjhampton pjhampton self-assigned this Sep 26, 2025
@vercel
Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
click-ui Ready Ready Preview Comment Oct 27, 2025 9:29am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the visual presentation and state management of FileUpload components by repositioning progress bars to appear directly beneath file names and enhancing UI consistency.

  • Restructured layout to display progress bars under file names instead of in separate containers
  • Enhanced state management to prevent progress and success states from conflicting
  • Replaced inline styles with styled components and improved error state styling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/components/FileUpload/FileUpload.tsx Restructured file info layout, moved progress bar positioning, and improved state-based rendering logic
src/components/FileUpload/FileMultiUpload.tsx Applied consistent layout changes and state management improvements to match FileUpload component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@crisalbu crisalbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect!

Copy link
Member

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One suggestion about Intl.NumberFormat.

Also, for these kinds of changes, screenshots of the new changes would be very helpful

@ariser ariser merged commit 184ea5a into main Oct 27, 2025
6 checks passed
@ariser ariser deleted the pjhampton/file-upload-fixes branch October 27, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants