- 
                Notifications
    
You must be signed in to change notification settings  - Fork 614
 
Add gotData and endOfProcess handlers #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            velom
  wants to merge
  2
  commits into
  ClickHouse:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
velom:on-handlers
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +168
        
        
          −4
        
        
          
        
      
    
  
  
     Open
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            2 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| 
          
            
          
           | 
    @@ -32,6 +32,8 @@ type onProcess struct { | |||||
| progress func(*Progress) | ||||||
| profileInfo func(*ProfileInfo) | ||||||
| profileEvents func([]ProfileEvent) | ||||||
| gotData func() | ||||||
| endOfProcess func() | ||||||
| } | ||||||
| 
     | 
||||||
| func (c *connect) firstBlock(ctx context.Context, on *onProcess) (*proto.Block, error) { | ||||||
| 
          
            
          
           | 
    @@ -143,6 +145,9 @@ func (c *connect) process(ctx context.Context, on *onProcess) error { | |||||
| func (c *connect) processImpl(ctx context.Context, on *onProcess) error { | ||||||
| c.readerMutex.Lock() | ||||||
| defer c.readerMutex.Unlock() | ||||||
| if on.endOfProcess != nil { | ||||||
| defer on.endOfProcess() | ||||||
| } | ||||||
| 
     | 
||||||
| for { | ||||||
| if c.reader == nil { | ||||||
| 
          
            
          
           | 
    @@ -178,6 +183,9 @@ func (c *connect) handle(ctx context.Context, packet byte, on *onProcess) error | |||||
| } | ||||||
| if block.Rows() != 0 && on.data != nil { | ||||||
| on.data(block) | ||||||
| if on.gotData != nil { | ||||||
| on.gotData() | ||||||
| 
         There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 
        Suggested change
       
    
 why doesn't gotData take block? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you'd like to, I can add it  | 
||||||
| } | ||||||
| } | ||||||
| case proto.ServerException: | ||||||
| return c.exception() | ||||||
| 
          
            
          
           | 
    ||||||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Licensed to ClickHouse, Inc. under one or more contributor | ||
| // license agreements. See the NOTICE file distributed with | ||
| // this work for additional information regarding copyright | ||
| // ownership. ClickHouse, Inc. licenses this file to you under | ||
| // the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| 
     | 
||
| package clickhouse_api | ||
| 
     | 
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| 
     | 
||
| "github.com/ClickHouse/clickhouse-go/v2" | ||
| ) | ||
| 
     | 
||
| func EndOfProcessAndGotData() error { | ||
| conn, err := GetNativeConnection(clickhouse.Settings{ | ||
| "send_logs_level": "trace", | ||
| }, nil, nil) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| var totalBlocks int | ||
| // use context to pass a call back for end of process and got data | ||
| ctx := clickhouse.Context(context.Background(), clickhouse.WithEndOfProcess(func() { | ||
| fmt.Println("process is finished") | ||
| }), clickhouse.WithGotData(func() { | ||
| totalBlocks++ | ||
| })) | ||
| 
     | 
||
| rows, err := conn.Query(ctx, "SELECT number from numbers(1000000) LIMIT 1000000") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer rows.Close() | ||
| 
     | 
||
| for rows.Next() { | ||
| } | ||
| 
     | 
||
| fmt.Printf("Total data blocks: %d\n", totalBlocks) | ||
| return rows.Err() | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Licensed to ClickHouse, Inc. under one or more contributor | ||
| // license agreements. See the NOTICE file distributed with | ||
| // this work for additional information regarding copyright | ||
| // ownership. ClickHouse, Inc. licenses this file to you under | ||
| // the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| 
     | 
||
| package std | ||
| 
     | 
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| 
     | 
||
| "github.com/ClickHouse/clickhouse-go/v2" | ||
| ) | ||
| 
     | 
||
| func EndOfProcessAndGotData() error { | ||
| conn, err := GetStdOpenDBConnection(clickhouse.Native, clickhouse.Settings{ | ||
| "send_logs_level": "trace", | ||
| }, nil, nil) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| var totalBlocks int | ||
| // use context to pass a call back for end of process and got data | ||
| ctx := clickhouse.Context(context.Background(), clickhouse.WithEndOfProcess(func() { | ||
| fmt.Println("process is finished") | ||
| }), clickhouse.WithGotData(func() { | ||
| totalBlocks++ | ||
| })) | ||
| 
     | 
||
| rows, err := conn.QueryContext(ctx, "SELECT number from numbers(1000000) LIMIT 1000000") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer rows.Close() | ||
| 
     | 
||
| for rows.Next() { | ||
| } | ||
| 
     | 
||
| fmt.Printf("Total data blocks: %d\n", totalBlocks) | ||
| return rows.Err() | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference of
gotDatavsdata? Other than the function signature?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datais "internal" handler set by library itself during query start:clickhouse-go/conn_query.go
Lines 67 to 84 in 46d2298