-
-
Notifications
You must be signed in to change notification settings - Fork 888
Add disable private sub #4627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheArchitect19
wants to merge
44
commits into
Cloud-CV:master
Choose a base branch
from
TheArchitect19:add_disable_private_sub
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add disable private sub #4627
Changes from 13 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
6eb7738
Add feature to disable private submission
Harshit28j 5e85318
add test case fix for private submission disable feature
Harshit28j 288f96d
Removed console.log
Harshit28j 6647892
add option disable changes & docs
Harshit28j 9d8b8fc
Merge branch 'master' into add_disable_private_sub
gchhablani 45925c7
feat: Add feature to disable private submission
TheArchitect19 68e94b9
feat: Add feature to disable private submission
TheArchitect19 a902135
refactor: removed conflicts
TheArchitect19 03795c3
Merge branch 'master' of https://github.com/TheArchitect19/EvalAI int…
TheArchitect19 b1f46ef
feat: added unit test for makeSubmission
TheArchitect19 8b97728
feat: added unit test for makeSubmission
TheArchitect19 827be74
feat: added unit test for makeSubmission
TheArchitect19 f296f18
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 6cf99d7
Merge branch 'master' of https://github.com/TheArchitect19/EvalAI int…
TheArchitect19 370c4e6
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 fc88765
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 1032bb8
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 46d70bf
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 93045f5
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 351395e
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 2365d0b
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 00ec830
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 22657b6
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 f7faf27
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 0336b08
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 25cea09
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 3aa40e9
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 b3d53d3
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 ba5dc1d
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 efc55be
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 33892e8
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 a2eeb4f
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 38a58e2
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 3121cfe
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 f19c359
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 9b3bb6c
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 049c863
Merge branch 'master' of https://github.com/TheArchitect19/EvalAI int…
TheArchitect19 475faec
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 ae0acf7
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 03485a0
feat: added unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 aa77a49
feat: removed unit test toggleDisablePrivateSubmission(ev)
TheArchitect19 b786c03
Merge branch 'master' of https://github.com/TheArchitect19/EvalAI int…
TheArchitect19 881502c
refactor: my-submission
TheArchitect19 cd5e4f8
Merge branch 'master' into add_disable_private_sub
TheArchitect19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 18 additions & 0 deletions
18
apps/challenges/migrations/0113_challenge_disable_private_submission.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Generated by Django 2.2.20 on 2024-08-31 06:42 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("challenges", "0112_challenge_sqs_retention_period"), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name="challenge", | ||
name="disable_private_submission", | ||
field=models.BooleanField(default=False), | ||
), | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,7 @@ <h6>My Participated Team: {{challenge.participated_team_name}}</h6> | |
<th class="fs-18 w-300" ng-if="challenge.isChallengeHost && | ||
!challenge.isStaticCodeUploadChallenge" data-field="file">Environment Logs</th> | ||
<th class="align-center fs-18 w-300" data-field="file">Submitted at</th> | ||
<th class="align-center fs-18 w-300" ng-if="challenge.currentPhaseLeaderboardPublic" | ||
<th class="align-center fs-18 w-300" ng-if="!challenge.disable_private_submission && challenge.currentPhaseLeaderboardPublic" | ||
data-field="file"> | ||
Show on leaderboard</th> | ||
<th class="fs-18 w-300" data-field="isBaseline" ng-if="challenge.isChallengeHost">Baseline | ||
|
@@ -121,7 +121,7 @@ <h6>My Participated Team: {{challenge.participated_team_name}}</h6> | |
|
||
<td>{{key.submitted_at | date:'medium'}}</td> | ||
|
||
<td ng-if="challenge.currentPhaseLeaderboardPublic" class="center"> | ||
<td ng-if="!challenge.disable_private_submission && challenge.currentPhaseLeaderboardPublic" class="center"> | ||
|
||
<input ng-checked="key.is_public" ng-if="!challenge.isCurrentPhaseRestrictedToSelectOneSubmission" | ||
ng-model="challenge.submissionVisibility[key.id]" type="checkbox" | ||
id="isPublic{{ key.id }}" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this check in
my-submissions
page? My submissions should ideally display all the submissions for a user.