Skip to content

fix: replace virtual thread executor for http request processing #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2024
Merged

fix: replace virtual thread executor for http request processing #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c78820b
fix: replace virtual thread executor for http request processing
derklaro Sep 30, 2024
ce6c40f
use custom cached thread pool
derklaro Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions ...st-module/src/main/java/eu/cloudnetservice/ext/modules/rest/config/RestConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package eu.cloudnetservice.ext.modules.rest.config;

import com.google.common.base.Preconditions;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
import eu.cloudnetservice.ext.rest.api.config.ComponentConfig;
import eu.cloudnetservice.ext.rest.api.config.CorsConfig;
import eu.cloudnetservice.ext.rest.api.config.HttpProxyMode;
Expand All @@ -25,12 +26,15 @@
import eu.cloudnetservice.ext.rest.api.connection.HttpConnectionInfoResolver;
import eu.cloudnetservice.ext.rest.api.util.HostAndPort;
import java.util.List;
import java.util.concurrent.Executors;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import lombok.NonNull;
import org.jetbrains.annotations.Nullable;

public record RestConfiguration(
int maxContentLength,
int requestDispatchThreadLimit,
boolean disableNativeTransport,
@NonNull CorsConfig corsConfig,
@NonNull HttpProxyMode proxyMode,
Expand All @@ -42,6 +46,7 @@ public record RestConfiguration(

public static final RestConfiguration DEFAULT = new RestConfiguration(
ComponentConfig.DEFAULT_MAX_CONTENT_LENGTH,
50,
false,
CorsConfig.builder()
.addAllowedOrigin("*")
Expand Down Expand Up @@ -70,14 +75,27 @@ public void validate() {
}

public @NonNull ComponentConfig toComponentConfig() {
var requestDispatchThreadFactory = new ThreadFactoryBuilder()
.setDaemon(true)
.setPriority(Thread.NORM_PRIORITY)
.setNameFormat("rest-request-dispatcher-%d")
.build();
var requestDispatchExecutor = new ThreadPoolExecutor(
1,
this.requestDispatchThreadLimit,
30L,
TimeUnit.SECONDS,
new LinkedBlockingQueue<>(),
requestDispatchThreadFactory);

return ComponentConfig.builder()
.corsConfig(this.corsConfig)
.haProxyMode(this.proxyMode)
.maxContentLength(this.maxContentLength)
.sslConfiguration(this.sslConfiguration)
.executorService(requestDispatchExecutor)
.disableNativeTransport(this.disableNativeTransport)
.connectionInfoResolver(this.httpConnectionInfoResolver())
.executorService(Executors.newVirtualThreadPerTaskExecutor())
.build();
}

Expand Down