Skip to content

Fix memory leaks #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix memory leaks #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7b4684
fix memory leak
vitSkalicky May 1, 2024
0d11471
Improve comments
vitSkalicky May 1, 2024
7fbc55a
Fix another leak
vitSkalicky May 1, 2024
a1a88c3
Use curl_free() instead of free()
vitSkalicky May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sources/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,9 @@ namespace WebDAV
{
pugi::xml_node href = response.node().select_node("*[local-name()='href']").node();
std::string encode_file_name = href.first_child().value();
std::string resource_path = curl_unescape(encode_file_name.c_str(), static_cast<int>(encode_file_name.length()));
char* unescaped = curl_unescape(encode_file_name.c_str(), static_cast<int>(encode_file_name.length())); //this allocates new memory
std::string resource_path{unescaped}; // the data is copied
curl_free(unescaped);
auto target_path = target_urn.path();
auto target_path_without_sep = target_urn.path();
if (!target_path_without_sep.empty() && target_path_without_sep.back() == '/')
Expand Down
4 changes: 3 additions & 1 deletion sources/urn.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ namespace WebDAV

auto escape(void* request, const string& name) -> string
{
string path = curl_easy_escape(request, name.c_str(), static_cast<int>(name.length()));
char * escaped = curl_easy_escape(request, name.c_str(), static_cast<int>(name.length())); // allocates new memory
string path{escaped}; // this copies the data
curl_free(escaped); // must free the memory
return path;
}

Expand Down