feat: Upgrade to .NET 6, add CI workflow, and fix tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit completes the upgrade of the EventLogAnalyzer project to .NET 6,
introduces a GitHub Actions CI workflow, and addresses issues identified
during the process.
Key changes:
- Upgraded all projects (Console Client, EventLog, UnitTests) to target .NET 6 using the SDK-style project format.
- Replaced direct NUnit DLL reference with NuGet packages.
- Added `System.Diagnostics.EventLog` NuGet package for .NET 6 compatibility.
- Resolved build issues related to duplicate resources and assembly attributes.
- Created a GitHub Actions workflow (`.github/workflows/dotnet-build.yml`) that:
- Triggers on pushes to any branch, pull requests to `master`, and manually via `workflow_dispatch`.
- Runs on `windows-latest`.
- Restores dependencies, builds, and runs unit tests.
- Corrected branch name references in workflow triggers (from `main` to `master` and `*`).
- Fixed a failing unit test (`ShouldIgnoreGuids`) by correcting a malformed input string in the test case.
- Removed obsolete files (old build scripts, .NET Framework 2.0 artifacts, old solution files, unused .idc file).
- Updated `.gitignore` to exclude `Output/` and `.vs/` directories.
- Updated `README.md` with current build instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit completes the upgrade of the EventLogAnalyzer project to .NET 6, introduces a GitHub Actions CI workflow, and addresses issues identified during the process.
Key changes:
System.Diagnostics.EventLogNuGet package for .NET 6 compatibility..github/workflows/dotnet-build.yml) that:master, and manually viaworkflow_dispatch.windows-latest.maintomasterand*).ShouldIgnoreGuids) by correcting a malformed input string in the test case..gitignoreto excludeOutput/and.vs/directories.README.mdwith current build instructions.