Skip to content

fix: disable input elements in PRO upsell #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

RaduCristianPopescu
Copy link
Contributor

@RaduCristianPopescu RaduCristianPopescu commented Jul 21, 2025

Summary

Will affect visual aspect of the product

NO

Screenshots

CleanShot 2025-07-21 at 11 53 56@2x

Test instructions

  • Go to page and try to interact with filters.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/860

@RaduCristianPopescu RaduCristianPopescu self-assigned this Jul 21, 2025
@RaduCristianPopescu RaduCristianPopescu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 21, 2025
@RaduCristianPopescu RaduCristianPopescu requested review from HardeepAsrani and Soare-Robert-Daniel and removed request for HardeepAsrani July 21, 2025 08:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables input elements in the conditions control for non-PRO users to prevent interaction with PRO-only features. The change improves the user experience by making the upsell state more explicit through disabled form controls.

  • Adds early return in the onChangeCondtion function for non-PRO users
  • Disables all form controls (SelectControl and TextControl) when PRO features are not available
  • Refactors inline PRO check to use a consistent isPro variable

@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review July 21, 2025 12:20
@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 21, 2025

Plugin build for 7c3934d is ready 🛎️!

Note

You can preview the changes in the Playground

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 29, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit e1b8122 into development Jul 29, 2025
10 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/free-action branch July 29, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants