fix: exclude native gRPC assemblies from package content #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native gRPC assemblies (grpc_csharp_ext.*.dll, libgrpc_csharp_ext.*) were being packaged as contentFiles, causing them to appear as linked items in Solution Explorer when consuming the package. These files are still needed at runtime but should flow through transitively from the Grpc.Core dependency rather than being bundled in this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where native gRPC assemblies appeared as linked items in Solution Explorer when installing the package.
The previous approach (PR #32) added a
.targetsfile to hide the items, but this didn't work because the files were being packaged ascontentFileswithin the Otel4Vsix package itself.This fix removes the gRPC native files from the package during
dotnet packusing a Target that runs beforeGenerateNuspec. The files will still be available at runtime through the transitive Grpc.Core dependency.Files excluded:
grpc_csharp_ext.x64.dllgrpc_csharp_ext.x86.dlllibgrpc_csharp_ext.x64.dyliblibgrpc_csharp_ext.x64.soTest plan