[feat] sync node library when subgraph titles change #4461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a subgraph node is renamed, the node library sidebar now immediately reflects the updated display name. This ensures consistency between the canvas, breadcrumb navigation, and node library. Key changes: - Add updateNodeDefDisplayName method to nodeDefStore with reference preservation - Update TitleEditor to call nodeDefStore for subgraph title changes - Organize subgraph browser tests into dedicated folder - Add comprehensive unit test coverage for nodeDefStore
christian-byrne
commented
Jul 15, 2025
| @@ -336,4 +336,54 @@ test.describe('Node library sidebar', () => { | |||
| await comfyPage.page.waitForTimeout(1000) | |||
| expect(await tab.getNode('KSampler (Advanced)').count()).toBe(2) | |||
| }) | |||
|
|
|||
| test('Subgraph node display name updates in library when renamed', async ({ | |||
There was a problem hiding this comment.
We will skip this test later and then re-enable when subgraphs are re-added to sidebar.
christian-byrne
added
area:subgraph
subgraph-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures subgraph title changes are immediately reflected in the node library sidebar. When users rename a subgraph node, the node library shows the updated display name without requiring a reload.
Implementation preserves object references while updating both nodeDefsByName and nodeDefsByDisplayName mappings, plus LiteGraph registered node type titles for new instance creation.
subgraph-node-library-update-demo.mp4
┆Issue is synchronized with this Notion page by Unito