[fix] Prevent incorrect 'frontend_only' badges in subgraphs #4571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckend definitions Fixes #4566 The previous implementation created frontend_only definitions for ALL LiteGraph registered nodes, then relied on object spreading to overwrite them with backend definitions. This fragile pattern could fail in certain conditions, particularly in subgraphs, causing all nodes to show 'frontend_only' badges. The fix now only creates frontend_only definitions for nodes that genuinely lack backend definitions, eliminating the reliance on object spread ordering and preventing incorrect badge display.
|
christian-byrne
added
needs-backport
christian-byrne
added a commit
that referenced
this pull request
Aug 4, 2025
christian-byrne
added a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4566
This PR fixes an issue where pressing 'r' in a subgraph would cause all nodes to incorrectly display 'frontend_only' badges. The root cause was a fragile pattern in
updateVueAppNodeDefs()that created frontend_only definitions for ALL nodes first, then relied on object spreading to overwrite them - which could fail in certain conditions.The fix ensures frontend_only definitions are only created for nodes that genuinely lack backend definitions, eliminating the reliance on object spread ordering.
Related:
┆Issue is synchronized with this Notion page by Unito