[fix] Fix graph configuration callbacks not reaching subgraph nodes #4572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The onGraphConfigured and onAfterGraphConfigured callbacks were only being triggered on nodes in the root graph, missing nodes within subgraphs. This caused several critical issues: - Widget input configurations not set up in subgraph nodes - Primitive nodes not initializing properly in subgraphs - Reroute nodes not updating connection types in subgraphs - Audio upload widgets not restoring file paths in subgraphs Updated #addAfterConfigureHandler to use triggerCallbackOnAllNodes which recursively processes nodes in the entire graph hierarchy. Fixes #4569
|
christian-byrne
added
the
needs-backport
christian-byrne
added a commit
that referenced
this pull request
Aug 4, 2025
christian-byrne
added a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a critical issue where
onGraphConfiguredandonAfterGraphConfiguredcallbacks were only being triggered on root graph nodes, missing nodes within subgraphs.Impact
This bug caused several functionality issues in subgraphs:
Changes
#addAfterConfigureHandlerinapp.tsto usetriggerCallbackOnAllNodesTesting
Fixes #4569
┆Issue is synchronized with this Notion page by Unito