Feature/named parameter support #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds named parameter support to the Complex Heart library's make() factory method. The feature enables PHP 8.0+ named parameter syntax for improved code readability and flexibility when creating Value Objects, Entities, and Aggregates.
Key changes:
- Implemented named parameter detection and mapping logic in the
IsModeltrait - Added comprehensive test coverage for various named parameter scenarios
- Updated documentation across multiple wiki files to demonstrate the new feature
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/IsModel.php | Added core named parameter support with detection and mapping functionality |
| tests/TypeValidationTest.php | Added comprehensive test suite covering named parameters, mixed parameters, and error scenarios |
| wiki/Domain-Modeling-Value-Objects.md | Updated documentation with named parameter examples and benefits |
| wiki/Domain-Modeling-Entities.md | Added named parameter examples for Entity creation |
| wiki/Domain-Modeling-Aggregates.md | Updated to highlight named parameter benefits for complex constructors |
| README.md | Added named parameter support to the feature list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.