Feature/invariant violation aggregation #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exception handling
There was a problem hiding this comment.
Pull Request Overview
This PR implements invariant violation aggregation functionality, allowing multiple invariant violations to be collected and thrown together as a single exception, improving error reporting and developer experience.
- Adds an
Aggregatablecontract to distinguish which exceptions can be collected vs. thrown immediately - Implements aggregation logic in
HasInvariantstrait to collect multiple violations before throwing - Enhances
InvariantViolationexception with support for multiple violations and better error messages
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Exceptions/InvariantViolation.php | Enhanced to implement Aggregatable interface and support multiple violations with improved messaging |
| src/Traits/HasInvariants.php | Updated invariant checking logic to aggregate violations and handle non-aggregatable exceptions |
| src/IsModel.php | Added new() static method as an alias for make() for more idiomatic domain object creation |
| tests/TraitsTest.php | Added comprehensive test coverage for invariant violation aggregation scenarios |
| tests/TypeValidationTest.php | Added tests for the new new() static method functionality |
| tests/ValueObjectsTest.php | Updated comment to clarify non-aggregatable exception behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
othercodes
force-pushed
the
feature/invariant-violation-aggregation
branch
from
288e663 to
1b949d1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.