Skip to content

[CLI] Use full qualified imports if icon name conflict with Compose qualifiers #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

[CLI] Use full qualified imports if icon name conflict with Compose qualifiers #545

merged 1 commit into from
Jul 24, 2025

Conversation

egorikftp
Copy link
Member

@egorikftp egorikftp commented Jul 21, 2025 •
edited
Loading

Also

  • migrated to context parameters
  • migrated to kotlin-poet withIndent{} extension

@egorikftp egorikftp requested review from Goooler and LennartEgb July 21, 2025 17:55
@egorikftp egorikftp force-pushed the feature/full-qualifiers branch 2 times, most recently from 1d8486d to eb01a11 Compare July 22, 2025 06:39
@egorikftp egorikftp requested a review from vkatz July 22, 2025 08:24
@vkatz
Copy link
Contributor

vkatz commented Jul 22, 2025

ImageVector
Brush
Color
Offset

This qualifiers needs to be handled with
if (Icon.name == qualifier) fullName else shotName + import

@egorikftp egorikftp force-pushed the feature/full-qualifiers branch 3 times, most recently from 65d3b54 to 91928b5 Compare July 23, 2025 09:16
@egorikftp egorikftp force-pushed the feature/full-qualifiers branch from 91928b5 to 59e4424 Compare July 23, 2025 09:30
@egorikftp egorikftp merged commit 7f1568c into main Jul 24, 2025
3 checks passed
@egorikftp egorikftp deleted the feature/full-qualifiers branch July 24, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkatz vkatz vkatz left review comments

@Goooler Goooler Awaiting requested review from Goooler

@LennartEgb LennartEgb Awaiting requested review from LennartEgb

Assignees
No one assigned
Labels
feature-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow using full qualifiers when converting SVG to Compose with svgxml2imagevector CLI tool
2 participants
@egorikftp @vkatz