implement add teacher and student to school #8
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| # Check permission | ||
| if (school.admin != request.user or request.user.role != "teacher") and not request.user.is_staff: | ||
| return Response({'error': 'Only school admins and teachers can add students to schools'}, | ||
| status=status.HTTP_403_FORBIDDEN) |
There was a problem hiding this comment.
Bug: Faulty Logic Denies Teacher Student Access
The permission check uses or instead of and, preventing teachers from adding students. The condition (school.admin != request.user or request.user.role != "teacher") evaluates to True when the user is a teacher but not the admin, incorrectly denying access. This contradicts the docstring stating "school admins and teachers can add students".
| ) | ||
|
|
||
| valid_classes_qs = Class.objects.filter(name__in=assigned_class_names, school=school) | ||
| teacher_profile.assigned_classes.set(valid_classes_qs) |
There was a problem hiding this comment.
Bug: Missing Default Breaks Class Filtering
When assigned_classes is not provided in the request, data.get('assigned_classes') returns None, which causes Class.objects.filter(name__in=assigned_class_names, ...) to fail since name__in expects an iterable. The code should default to an empty list when the field is absent.
Note
Introduce dedicated teacher/student add-to-school endpoints with serializers, handling roles, memberships, and class assignments.
POST /schools/<school_id>/add-teacher-school/(add_teacher_to_school) andPOST /schools/<school_id>/add-student-school/(add_student_to_school).Userrole (teacher/student), creates/activatesSchoolMembership.TeacherProfile/StudentProfile; validates and assignsClass(es) for teachers and students.SchoolAddTeacherSerializer(email, teacher_role, assigned_classes) andSchoolAddStudentSerializer(email, assigned_class).core/urls.py; import serializers incore/views.py.Written by Cursor Bugbot for commit 385a398. This will update automatically on new commits. Configure here.