-
Notifications
You must be signed in to change notification settings - Fork 569
feat: Add Intelij Rider for Autoconfig support #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new RiderConfigurator class is introduced that extends JsonFileMcpConfigurator to configure the Model Context Protocol for JetBrains Rider with GitHub Copilot. The class initializes platform-specific mcp.json paths and provides a four-step installation guide for users. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
MCPForUnity/Editor/Clients/Configurators/RiderConfigurator.cs (1)
20-25: Installation steps are minimal; consider adding Rider‑specific pointers laterThe four installation steps are clear and usable as a starting point. As a follow‑up (not blocking), you might later expand them with Rider‑specific navigation hints (e.g., where to find the plugin/settings, or how to open the config directory) to reduce friction for less experienced users.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
MCPForUnity/Editor/Clients/Configurators/RiderConfigurator.cs(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: msanatan
Repo: CoplayDev/unity-mcp PR: 401
File: MCPForUnity/Editor/Clients/Configurators/VSCodeConfigurator.cs:10-18
Timestamp: 2025-11-27T21:09:35.011Z
Learning: VS Code GitHub Copilot MCP configuration supports mcp.json files placed directly in the Code/User directory: %APPDATA%\Code\User\mcp.json on Windows, ~/Library/Application Support/Code/User/mcp.json on macOS, and ~/.config/Code/User/mcp.json on Linux. This is in addition to workspace-scoped .vscode/mcp.json files.
🧬 Code graph analysis (1)
MCPForUnity/Editor/Clients/Configurators/RiderConfigurator.cs (1)
MCPForUnity/Editor/Models/McpClient.cs (1)
McpClient(5-55)
🔇 Additional comments (1)
MCPForUnity/Editor/Clients/Configurators/RiderConfigurator.cs (1)
10-16: Confirm .NET/Unity support forEnvironment.SpecialFolder.UserProfileand Rider path layoutThe OS-specific paths look correct and match the PR description, but there are two things worth double-checking:
- That
Environment.SpecialFolder.UserProfileis available and behaves as expected on all Unity/.NET targets you support (especially older LTS versions).- That GitHub Copilot in Rider actually resolves
mcp.jsonfrom the non‑versionedJetBrains/Riderdirectory (and not a versioned folder likeRider2024.2).If both assumptions are already validated in manual tests, this is fine as‑is; otherwise, it may be safer to align with whatever pattern you used in
VSCodeConfiguratoror factor out a small helper for “user home + config subpath” to keep behavior consistent.
Summary
RiderConfiguratorto enable automatic MCP configuration for JetBrains Rider with GitHub Copilot usersIsVsCodeLayout = trueas Rider stores settings in VS Code-compatible formatConfig Paths
%APPDATA%/JetBrains/Rider/mcp.json~/Library/Application Support/JetBrains/Rider/mcp.json~/.config/JetBrains/Rider/mcp.jsonTest Plan
☐ Open MCP for Unity window in Unity Editor
☐ Verify "Rider GitHub Copilot" appears in the client list
☐ Test "Check Status" button with Rider installed
☐ Test "Configure" button to auto-configure MCP settings
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.