Skip to content

missing fields AE fix #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

missing fields AE fix #322

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9440377
updating AssertionError on utterance pd column check to specify missi…
mjgaughan Oct 19, 2025
13038c7
fixing error re: Numpy type in AE fix
mjgaughan Oct 19, 2025
1aee185
adding list(missing__fields) for improved readability
mjgaughan Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions convokit/model/corpus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,9 +1548,10 @@ def from_pandas(
df["id"] = df.index

# checking if dataframes contain their respective required columns
missing_fields = pd.Index(columns).difference(utterances_df.columns)
assert (
pd.Series(columns).isin(utterances_df.columns).all()
), "Utterances dataframe must contain all primary data fields"
len(missing_fields) == 0
), f"Utterances dataframe is missing the following required fields: {missing_fields}"
Copy link
Collaborator

@ethanxia4 ethanxia4 Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use list(missing_fields) in assert error for slightly more readable formatting, other than that works great


utterance_meta_cols = extract_meta_from_df(utterances_df)

Expand Down