Change submodule ( Motion ) path ( Sources/Frameworks -> Frameworks ) #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goodocy Thank you. I will read through this later today. |
|
@DanielDahan Thank you for comment. |
|
Hmm... interesting Problem: |
|
Hi @goodocy, sorry I haven't had a chance to look into this issue. I will make some changes that externalize the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change submodule ( Motion ) path ( Sources/Frameworks -> Frameworks )
Package.swift - target - exclude does not work as intended
Reason
SPM (Swift Package Manager) does not support submodules, and when I checked it, I confirmed that when I updated the package, the material and motion conflict.
Currently CocoaPods, Carthage, and SPM are using Motion, so I suggest changing the Sources/Framework/Motion from the SPM management folder (Sources) to external.