[WIP] ch cluster+replica+ha #7111
Merged
+3,213
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…development start scripts
…nto uj/ch-cluster
kanwarujjaval
requested review from
Cookiezaurs,
ar2rsawseen,
Copilot and
pnrgenc
Contributor
There was a problem hiding this comment.
Pull request overview
This work-in-progress PR introduces ClickHouse cluster, replication, and high availability support to Countly. The changes focus on configuration, cluster-aware mutation management, and improved development tooling.
Key changes:
- Added comprehensive ClickHouse cluster configuration with support for sharding, replication, and HA modes
- Modified mutation validation logic to handle cluster mode with
_localtable suffixes - Cleaned up extensive debug logging in API startup, converting console.log calls to structured logging
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added dev start scripts with symlink support and ClickHouse cluster test script |
| api/jobs/mutationManagerJob.js | Added cluster-aware mutation validation logic using ClusterManager to determine appropriate table names |
| api/configextender.js | Added documentation comments explaining ClickHouse configuration override mechanism |
| api/config.sample.js | Added extensive ClickHouse cluster, replication, dictionary, and identity configuration sections |
| api/api.js | Removed debug console.log statements and replaced with structured log utility calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pnrgenc
approved these changes
Dec 24, 2025
… for testing in UnifiedEventSink and UnifiedEventSource
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 21 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nto uj/ch-cluster
Cookiezaurs
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.