Add biome return value for shipwrecks in isViableStructurePos, similar to villages #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Didn't realize this before but this causes a collision because regular oceans are ID 0 which clashes with the return value for an invalid structure position, my apologies. Still, I think there's value in refactoring this function to maybe add a pointer to hold a biome return value, in a similar way to how getStructurePos does so for position. I'll keep this as a draft for the time being if that's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convenient to have for analysis, as beach vs. ocean have different behavior when rolling for ship type and orientation (and thereby, the resulting loot)