Skip to content

Resolves gh-25: Draws hidden points of interest for screenreaders. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ulexus merged 1 commit into from
Oct 8, 2025
Merged

Resolves gh-25: Draws hidden points of interest for screenreaders. #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions src/room.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,25 @@ export class SpatialRoom extends EventTarget {
}
}

// Draw points of interest, which are hidden text labels only.
// Note: these are drawn first so they are under the listener possition.
let pois = self.svg.selectAll("text.poi").data(self.data.pointsOfInterest)
pois.enter().append("text")
.attr("text-anchor", "middle")
.attr("class", "poi")
.text(function(d) {
return d.name
})
.merge(pois)
.attr("x", function(d) {
return self.scaleX(
d.location.x + self.data.dimensions.width / 2)
})
.attr("y", function(d) {
return self.scaleY(
self.data.dimensions.depth/2-d.location.z)
})

// Add listener position indicator
let loc = self.svg.selectAll('circle.listener').data([{
x: self.listenerPosition.toSVG().x,
Expand Down Expand Up @@ -242,10 +261,16 @@ export class SpatialRoom extends EventTarget {
.attr("text-anchor", "middle")
.attr("class", "sourceText")
.attr("fill", "grey")
.text(function(d) { return d.name })
.text(function(d) {
return d.name
})
.merge(labels)
.attr("x", function(d) { return self.scaleX(d.location.x + self.data.dimensions.width/2) })
.attr("y", function(d) { return self.scaleY(self.data.dimensions.depth/2-d.location.z) })
.attr("x", function(d) {
return self.scaleX(d.location.x + self.data.dimensions.width/2)
})
.attr("y", function(d) {
return self.scaleY(self.data.dimensions.depth/2-d.location.z)
})
.attr("dy", "2em")

this.dispatchEvent(new Event("redraw"))
Expand Down