Skip to content

Conversation

@realSquidCoder
Copy link
Contributor

Adds a button to the eraser menu to open gui/mass-remove

@realSquidCoder realSquidCoder marked this pull request as ready for review March 23, 2025 00:19
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, looks great!

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget the changelog entry!

@realSquidCoder
Copy link
Contributor Author

don't forget the changelog entry!

how should i phrase this tho @myk002 ?

@myk002
Copy link
Member

myk002 commented Mar 23, 2025

don't forget the changelog entry!

how should i phrase this tho @myk002 ?

Similarly to how you documented the overlay itself:

`gui/mass-remove`: added a button to the bottom toolbar when eraser mode is active for launching `gui/mass-remove`

@realSquidCoder
Copy link
Contributor Author

if you can merge this really fast then i can add the changelog for the other pr withuot conflicts

@myk002
Copy link
Member

myk002 commented Mar 23, 2025

if you can merge this really fast then i can add the changelog for the other pr withuot conflicts

as soon as CI passes

@myk002 myk002 merged commit 22842e4 into DFHack:master Mar 23, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in 51.08-r2 Mar 23, 2025
@realSquidCoder realSquidCoder deleted the squid-destroytoolbar branch March 23, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants