Skip to content

Conversation

@SilasD
Copy link
Contributor

@SilasD SilasD commented Aug 17, 2025

Two minor fixes to internal/common/pedestal.lua. No user-visible changes, except that removing items from a pedestal using the DFHack interface will work correctly.

Well-tested. Extensive comments in each commit.

@ab9rf
Copy link
Member

ab9rf commented Aug 17, 2025

This alters user-facing behavior and thus needs a changelog

@ab9rf
Copy link
Member

ab9rf commented Aug 19, 2025

I'm going to take the slight risk of merging this for release without acceptance testing since it's a straightforward bug fix

@ab9rf ab9rf merged commit 7a18409 into DFHack:master Aug 19, 2025
10 checks passed
@SilasD
Copy link
Contributor Author

SilasD commented Aug 19, 2025

Thanks!

So GitHub doesn't carry per-commit comments along when it transfers commits to a merge.

There's not even an indication that the comments exist. I don't like that.

I would guess that's because the comments are not core Git.

Edit: I just bet that the comments will disappear when I delete that branch.

Edit: yes, they did. Lesson: don't use comments as permanent documentation of the reasons for code changes, because they are ephemeral. Use the commit log messages instead.

Edit: No, they're preserved, just need to click the speech-bubble icon instead of the commit itself. Good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants