Skip to content

Conversation

@vmcj
Copy link
Member

@vmcj vmcj commented Sep 27, 2025

NPM is another packagemanager for JS. So we use composer first and when we can't find the package there we check with npm.

This change does require more changes for maintainer-install & any checkout.

If we do this it makes introducing MathJax a lot easier and we can now also version control other javascript libraries.

@nickygerritsen
Copy link
Member

If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies

@vmcj
Copy link
Member Author

vmcj commented Sep 27, 2025

If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies

So also remove JS dependencies in composer and add them in npm? I'm fine with either of the 2 but for adaptation doing it in composer is an easier learningpath.

I somehow never used yarn but if that's the better of the 2 but I have no experience with that translation path.

I also think we should only do this in the next release so we have some time to discuss.

@nickygerritsen
Copy link
Member

If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies

So also remove JS dependencies in composer and add them in npm? I'm fine with either of the 2 but for adaptation doing it in composer is an easier learningpath.

I somehow never used yarn but if that's the better of the 2 but I have no experience with that translation path.

I also think we should only do this in the next release so we have some time to discuss.

I think it doesn't make sense to have 2 package managers for frontend dependencies, that's why I suggest using npm (or yarn, which can read the same package.json file) for all.

@vmcj vmcj marked this pull request as draft September 28, 2025 11:10
@vmcj vmcj force-pushed the introduce_npm branch 4 times, most recently from d4096af to 3bfe280 Compare October 27, 2025 18:27
@vmcj vmcj marked this pull request as ready for review October 27, 2025 18:27
@vmcj
Copy link
Member Author

vmcj commented Oct 27, 2025

The other packages are harder to either find (dataTables) or don't work 1-on-1 (font-awesome). I'll look at those in another PR. Reviewing is easiest commit by commit and by just skipping the monaco one as that's the one touch most files.

vmcj added 11 commits October 27, 2025 19:29
Per commit we'll put the JS frontend libraries under control of a
javascript dependency manager similar to composer for PHP.
This requires removing it from composer and adding it to yarn.
Default it seemed to pick a development version. This complains that it
requires d3 also, that will be in the next commits.
This also fixes the issue that d3 as dependency is missing for nv3, note that
we can't update d3 yet because of this dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants