Wrap assignment inside if in parentheses for clarity #3167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
approved these changes
Oct 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
and also test against `nullptr` (even though that's zero, thus false by definition). To silence the coverity scan warning.
eldering
force-pushed
the
fix-coverity-warn-fopen
branch
from
8cbfb4c to
d49393a
Compare
This is causing some trouble on CI in our integration tests, e.g. https://github.com/DOMjudge/domjudge/actions/runs/18819431955/job/53692609380: ``` 2025-10-26T15:17:47.393646+00:00] request.ERROR: Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\BadRequestHttpException: "["An exception occurred while executing a query: SQLSTATE[40001]: Serialization failure: 1213 Deadlock found when trying to get lock; try restarting transaction"]" at ImportProblemService.php line 8 96 {"exception":"[object] (Symfony\\Component\\HttpKernel\\Exception\\BadRequestHttpException(code: 0): [\"An exception occurred while executing a query: SQLSTATE[40001 ]: Serialization failure: 1213 Deadlock found when trying to get lock; try restarting transaction\"] at /opt/domjudge/domserver/webapp/src/Service/ImportProblemService. php:896)"} [] ``` Related: #2848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also test against
nullptr(even though that's zero, thus false by definition).To silence coverity scan warning.